--- trunk/1.6.x/ccs-patch/README.ccs 2008/04/08 05:48:22 1093 +++ trunk/1.6.x/ccs-patch/README.ccs 2008/11/11 00:22:48 1817 @@ -1146,11 +1146,11 @@ Fix 2008/02/05 - @ Use find_task_by_vpid() instead of find_task_pid(). + @ Use find_task_by_vpid() instead of find_task_by_pid(). Kernel 2.6.24 introduced PID namespace. To search PID given from userland, the kernel needs to use - find_task_by_vpid() instead of find_task_pid(). + find_task_by_vpid() instead of find_task_by_pid(). Fix 2008/02/14 @@ -1360,7 +1360,7 @@ Version 1.6.0 2008/04/01 Feature enhancement release. -Fix 2008/??/?? +Fix 2008/04/14 @ Fix "Compilation failures" and "Initialization ordering bugs" with kernels before 2.4.30/2.6.11 . @@ -1369,10 +1369,362 @@ resulting compilation error at #include . I added #elif condition. - 2.6 kernels before 2.6.11 calls do_execve() before initialization of + CentOS 4.6's 2.6.9 kernel calls do_execve() before initialization of ccs_alloc(), resulting NULL pointer dereference. - I changed __initcall to fs_initcall. + I changed __initcall to core_initcall. - Some distributions with 2.6.9 kernels backported kzalloc() from 2.6.14 , + CentOS 4.6's 2.6.9 kernel backported kzalloc() from 2.6.14 , resulting compilation error at kzalloc(). I modified prototype of kzalloc(). + +Fix 2008/04/20 + + @ Fix "Compilation failures" with kernels before 2.4.30/2.6.11 . + + Turbolinux 10 Server's 2.6.8 kernel backported kzalloc() as an inlined + function, resulting compilation error at kzalloc(). + I converted kzalloc() from an inlined function into a macro. + +Fix 2008/04/21 + + @ Add workaround for gcc 3.2.2's inline bug. + + RedHat Linux 9's gcc 3.2.2 generated a bad code + if ((var_of_u8 & 0x000000BF) & 0x80000000) { } + where the expected code is + if ((var_of_u8 & 0xBF) & 0x80) { } + when embedding ccs_acl_type2() into print_entry(), + resulting runtime BUG(). + I added the expected code explicitly as a workaround. + +Fix 2008/05/06 + + @ Add memory quota. + + 1.5.x returns -ENOMEM when FindNextDomain() failed to create a new + domain, but I forgot to return -ENOMEM when find_next_domain() failed to + create a new domain. + + A domain is automatically created by find_next_domain() only if + the domain for the requested program doesn't exist. + This behavior is for the administrator's convenience. + The administrator needn't to know how many domains are needed for running + the whole programs in the system beforehand when developing the policy. + But the administrator does not want the kernel to reject execution of the + requested program when developing the policy. + + So, I think it is better to grant execution of programs even if + find_next_domain() failed to create a new domain than reject execution. + Thus, I decided not to return -ENOMEM when find_next_domain() failed to + create a new domain. This exception breaks the domain transition rules, + so I print "transition_failed" warning in /proc/ccs/domain_policy + when this exception happened. + + Also, to prevent the system from being halted by unexpectedly allocating + all kernel memory for the policy, I added memory quota. + This quota is configurable via /proc/ccs/meminfo like + + echo Shared: 1048576 > /proc/ccs/meminfo + echo Private: 1048576 > /proc/ccs/meminfo + +Version 1.6.1 2008/05/10 Bug fix release. + +Fix 2008/06/04 + + @ Check open mode of /proc/ccs/ interface. + + It turned out that I can avoid allocating memory for reading if + FMODE_READ is not set and memory for writing if FMODE_WRITE is not set. + + @ Wait for completion of /sbin/ccs-init . + + Since 2.4 kernel's call_usermodehelper() can't wait for termination of + the executed program, I was using the close() request of + /proc/ccs/meminfo to indicate that loading policy has finished. + But since /proc/ccs/meminfo could be accessed for setting memory quota + by /etc/ccs/ccs-post-init , I stopped using the close() request. + The policy loader no longer need to access /proc/ccs/meminfo to notify + the kernel that loading policy has finished. + +Fix 2008/06/05 + + @ Fix realpath for pipes and sockets. + + Kernel 2.6.22 and later use different method for calculating d_path(). + Since fs/realpath.c didn't notice the change, the realpath of pipes + appeared as "pipe:" rather than "pipe:[\$]" when they are opened via + /proc/PID/fd/ directory. + + @ Add process's information into /proc/ccs/query . + + While /proc/ccs/grant_log and /proc/ccs/reject_log contain process's + information, /proc/ccs/query doesn't contain it. + To be able to utilize ccs-queryd and ccs-notifyd more, I added it into + /proc/ccs/query . + +Fix 2008/06/10 + + @ Allow using patterns for globally readable files. + + To allow users specify locale specific files to globally readable files, + I relaxed checking in update_globally_readable_entry(). + +Fix 2008/06/11 + + @ Remove ALLOW_ENFORCE_GRACE parameter. + + Since unexpected requests caused by doing software updates can happen + in all profiles, users likely have to write ALLOW_ENFORCE_GRACE=enabled + to all profiles. And it makes meaningless to allow users to selectively + enable specific profile's ALLOW_ENFORCE_GRACE parameter. + So, I removed ALLOW_ENFORCE_GRACE parameter. + Now, the system behaves as if ALLOW_ENFORCE_GRACE=enabled is specified. + The behavior of "delayed enforcing" mode is defined in the following + order. + + (1) The requests are rejected immediately if nobody is opening + /proc/ccs/query interface. + (2) The requests will be rejected in 10 seconds if somebody other than + ccs-queryd (such as less(1)) is opening /proc/ccs/query interface, + for such process doesn't write dummy decisions. + +Fix 2008/06/22 + + @ Pass escaped pathname to audit_execute_handler_log(). + + I was passing unescaped pathname to audit_execute_handler_log() + which causes /proc/ccs/grant_log contain whitespace characters + if execute handler's pathname contains whitespace characters. + +Fix 2008/06/25 + + @ Return 0 when ccs_may_umount() succeeds. + + I forgot to clear error value in ccs_may_umount() when the requested + directory didn't match "deny_unmount" keyword. As a result, any umount() + request with RESTRICT_UNMOUNT=enforcing returned -EPERM error. + +Version 1.6.2 2008/06/25 Usability enhancement release. + +Fix 2008/07/01 + + @ Fix "Compilation failure" with 2.4.20 kernel. + + RedHat Linux 9's 2.4.20 kernel backported O(1) scheduler patch, + resulting compilation error at ccs_load_policy(). + I added defined(TASK_DEAD) check. + +Fix 2008/07/08 + + @ Don't check permissions if vfsmount is NULL. + + Some filesystems (e.g. unionfs) pass NULL vfsmount. + I changed fs/tomoyo_file.c not to try to calculate pathnames + if vfsmount is NULL. + +Version 1.6.3 2008/07/15 Bug fix release. + +Fix 2008/08/21 + + @ Add workaround for gcc 4.3's bug. + + In some environments, fs/tomoyo_network.c could not be compiled + because of gcc 4.3's bug. + I modified save_ipv6_address() to use "integer literal" value + instead for "static const u8" variable. + + @ Change prototypes of some functions. + + To support 2.6.27 kernels, I replaced "struct nameidata" with + "struct path" for some functions. + + @ Detect distributor specific patches automatically. + + Since kernels with AppArmor patch applied is increasing, + I introduced a mechanism which determines whether specific patches + are applied or not, based on "#define" directives in the patches. + +Fix 2008/08/29 + + @ Remove "-ccs" suffix from Makefile's EXTRAVERSION. + + To reduce conflicts on Makefile's EXTRAVERSION, + I removed "-ccs" suffix from ccs-patch-2.\*.diff . + Those who build kernels without using specs/build-\*.sh , + please edit EXTRAVERSION tag manually so that original kernels + will not be overwritten by TOMOYO Linux kernels. + +Version 1.6.4 2008/09/03 Minor update release. + +Fix 2008/09/09 + + @ Add "try again" response to "delayed enforcing" mode. + + To be able to handle pathname changes caused by software updates, + "delayed enforcing" mode was introduced. It allows administrator to + grant access requests which are about to be rejected by the kernel. + + To be able to handle pathname changes caused by software updates better, + I introduced "try again" response. As "delayed enforcing" mode sleeps + a process which violated policy, administrator can update policy while + the process is sleeping. This "try again" response allows administrator + to restart policy checks from the beginning after updating policy. + +Fix 2008/09/11 + + @ Remember whether the process is allowed to write to /proc/ccs/ interface. + + Since programs for manipulating policy (e.g. ccs-queryd ) are installed + in the form of RPM/DEB packages, these programs lose the original + pathnames when they are updated by the package manager. The package + manager renames these programs before deleting these programs so that + the package manager can rollback the operation. + This causes a problem when the programs are listed into /proc/ccs/manager + using pathnames, as the programs will no longer be allowed to write to + /proc/ccs/ interface while the process of old version of the program is + alive. + + To solve this problem, I modified to remember the fact that the process + is once allowed to write to /proc/ccs/ interface until the process + attempts to execute a different program. + This change makes it impossible to revoke permission to write to + /proc/ccs/ interface without killing the process, but it will be better + than nonfunctioning ccs-queryd program. + +Fix 2008/09/19 + + @ Allow selecting a domain by PID. + + Sometimes we want to know what ACLs are given to specific PID, but + finding a domainname for that PID from /proc/ccs/.process_status and + reading ACLs from /proc/ccs/domain_policy by the domainname is very slow. + Thus, I modified /proc/ccs/domain_policy to allow selecting a domain by + PID. For example, to read domain ACL of current process from bash, + run as follows. + + # exec 100<>/proc/ccs/domain_policy + # echo select pid=$$ >&100 + # while read -u 100; do echo $REPLY; done + + If a domain is once selected by PID, reading /proc/ccs/domain_policy will + print only that domain if that PID exists or print nothing otherwise. + + @ Disallow concurrent /proc/ccs/ access using the same file descriptor. + + Until now, one process can read() from /proc/ccs/ while other process + that shares the file descriptor can write() to /proc/ccs/ . + But to implement "Allow selecting a domain by PID" feature, I disabled + concurrent read()/write() because the feature need to modify read buffer + while writing. + +Fix 2008/10/01 + + @ Add retry counter into /proc/ccs/query . + + To be able to handle some of queries from /proc/ccs/query without user's + interaction, I added retry counter for avoiding infinite loop caused by + "try again" response. + +Fix 2008/10/07 + + @ Don't transit to new domain until do_execve() succeeds. + + Until now, a process's domain was updated to new domain which the process + will belongs to before do_execve() succeeds so that the kernel can do + permission checks for interpreters and environment variables based on + new domain. But this caused a subtle problem when other process sends + signals to the process, for the process returns to old domain if + do_execve() failed. + + So, I modified to pass new domain to functions so that I can avoid + modifying a process's domain before do_execve() succeeds. + + @ Use old task state for audit logs. + + Until now, audit logs were generated using the task state after + processing "; set task.state" part. But to generate accurate logs, + I modified to save the task state before processing "; set task.state" + part and use the saved state for audit logs. + + @ Use a structure for passing parameters. + + As the number of parameters is increasing, I modified to use a structure + for passing parameters. + +Fix 2008/10/11 + + @ Remove domain_acl_lock mutex. + + I noticed that I don't need to keep all functions that modify an ACL of + a domain mutually exclusive. Since each functions handles different type + of ACL, locking is needed only when they append an ACL to a domain. + So, I modified to use local locks. + +Fix 2008/10/14 + + @ Fix ccs_check_condition() bug. + + Due to a bug in ccs_check_condition(), it was impossible to use + task.state[0] task.state[1] task.state[2] inside condition part + if the ACL does not treat a pathname. For example, an ACL like + + allow_network TCP connect @HTTP_SERVERS 80 if task.state[0]=100 + + didn't work. + +Fix 2008/10/15 + + @ Show process information in /proc/ccs/.process_status . + + To be able to determine a process's type, I added a command "info PID" + which returns process information of the specified PID in + "PID manager=\* execute_handler=\* state[0]=\$ state[1]=\$ state[2]=\$" + format. + +Fix 2008/10/20 + + @ Use rcu_dereference() when walking the list. + + I was using "dependency ordering" for appending an element to a list + without asking the reader to take a lock. But "dependency ordering" + is not respected by DEC Alpha or by some aggressive value-speculation + compiler optimizations. + + On such environment, use of "dependency ordering" can lead to system + crash because the reader might read uninitialized value of newly + appended element. + + To prevent the reader from reading uninitialized value of newly appended + element, I inserted rcu_dereference() when walking the list. + +Fix 2008/11/04 + + @ Use sys_getpid() instead for current->pid. + + Kernel 2.6.24 introduced PID namespace. + + To compare PID given from userland, I can't use current->pid. + So, I modified to use sys_getpid() instead for current->pid. + + I modified to use task_tgid_nr_ns() for 2.6.25 and later instead for + current->tgid when checking /proc/self/ in get_absolute_path(). + +Fix 2008/11/07 + + @ Fix is_alphabet_char(). + + is_alphabet_char() should match 'A' - 'Z' and 'a' - 'z', + but was matching from 'A' - 'F' and 'a' - 'f'. + + @ Add /proc/ccs/.execute_handler . + + Process information became visible to userspace by + "Show process information in /proc/ccs/.process_status" feature. + However, programs specified by execute_handler keyword may run as + non root user, making it impossible to see process information. + + So, I added a new interface that allows execute handler processes + to see process information. The content of /proc/ccs/.execute_handler is + identical to /proc/ccs/.process_status . + +Version 1.6.5 2008/11/11 Third anniversary release.